]> git.karo-electronics.de Git - karo-tx-linux.git/commit
dm raid1: fail writes if errors are not handled and log fails
authorMikulas Patocka <mpatocka@redhat.com>
Tue, 16 Feb 2010 18:42:55 +0000 (18:42 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 2 Mar 2011 14:46:43 +0000 (09:46 -0500)
commit6934e92473f477a70ce50d83105a5ae346d1fb2c
tree031f6654d1271a1537582fef86b912881abdedc4
parent0acbae9a85a0f3cce43d7334c645eccbeee8cc27
dm raid1: fail writes if errors are not handled and log fails

commit 5528d17de1cf1462f285c40ccaf8e0d0e4c64dc0 upstream.

If the mirror log fails when the handle_errors option was not selected
and there is no remaining valid mirror leg, writes return success even
though they weren't actually written to any device.  This patch
completes them with EIO instead.

This code path is taken:
do_writes:
bio_list_merge(&ms->failures, &sync);
do_failures:
if (!get_valid_mirror(ms)) (false)
else if (errors_handled(ms)) (false)
else bio_endio(bio, 0);

The logic in do_failures is based on presuming that the write was already
tried: if it succeeded at least on one leg (without handle_errors) it
is reported as success.

Reference: https://bugzilla.redhat.com/show_bug.cgi?id=555197

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
Cc: maximilian attems <max@stro.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/md/dm-raid1.c