]> git.karo-electronics.de Git - karo-tx-linux.git/commit
Fix oops caused by queue refcounting failure
authorJames Bottomley <James.Bottomley@HansenPartnership.com>
Wed, 25 May 2011 20:52:14 +0000 (15:52 -0500)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Thu, 17 May 2012 15:20:43 +0000 (11:20 -0400)
commit697b4f1473ddc06a0fb77d80281cf57f5fcf5b0a
treeed72ce04badf905fb9f43bdae3e72accc9a855f6
parentcf72dbd757c58e568df27c1d6b8c96e0642b8384
Fix oops caused by queue refcounting failure

commit e73e079bf128d68284efedeba1fbbc18d78610f9 upstream.

In certain circumstances, we can get an oops from a torn down device.
Most notably this is from CD roms trying to call scsi_ioctl.  The root
cause of the problem is the fact that after scsi_remove_device() has
been called, the queue is fully torn down.  This is actually wrong
since the queue can be used until the sdev release function is called.
Therefore, we add an extra reference to the queue which is released in
sdev->release, so the queue always exists.

Reported-by: Parag Warudkar <parag.lkml@gmail.com>
Signed-off-by: James Bottomley <jbottomley@parallels.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
drivers/scsi/scsi_scan.c
drivers/scsi/scsi_sysfs.c