]> git.karo-electronics.de Git - karo-tx-linux.git/commit
Revert "Staging: drivers: rtl8188eu: use sizeof(*ptr) instead of sizeof(struct)"
authorHans de Goede <hdegoede@redhat.com>
Sun, 5 Jun 2016 19:01:18 +0000 (21:01 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Jun 2016 18:21:45 +0000 (11:21 -0700)
commit6982f867e058f0c6c8d3eeb4ef305efd7d7f4c8c
tree1cd619c2c8c558bb709340bc72cd8855298ed39f
parenta9cc4006155a68dd0940728f4f222dd035180904
Revert "Staging: drivers: rtl8188eu: use sizeof(*ptr) instead of sizeof(struct)"

This reverts commit 99aded71b52c ("Staging: drivers: rtl8188eu: use
sizeof(*ptr) instead of sizeof(struct)").

This commit is wrong, as adapt->HalData has a type of "void *", so
now we are allocating a much to small struct, which causes the driver
to overwrite random memory which leads to a non working driver and
various system crashes.

Cc: Jacky Boen <aqiank@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/hal/usb_halinit.c