]> git.karo-electronics.de Git - linux-beck.git/commit
net/phy: micrel: fix bugged test on device tree loading for ksz9021
authorHubert Chaumette <hchaumette@adeneo-embedded.com>
Tue, 22 Apr 2014 13:01:04 +0000 (15:01 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 23 Apr 2014 18:58:58 +0000 (14:58 -0400)
commit6a1197457f9ec085871d2f842e1bbbe9d13216da
tree299f154b255bfc8d178e158a2db6a95137d80a91
parent6a51b5e4d59e00051e65e836520912cd7c717be1
net/phy: micrel: fix bugged test on device tree loading for ksz9021

In ksz9021_load_values_from_of() val2 to val4 aren't tested against their
initialization value.
This causes the test to always succeed, and this value to be used as if it
was loaded from the devicetree instead of being ignored, in case of a
missing/invalid property in the ethernet OF device node.
As a result, the value "0" is written to the relevant registers.

Change the conditions to test against the right initialization value.

Signed-off-by: Hubert Chaumette <hchaumette@adeneo-embedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/micrel.c