]> git.karo-electronics.de Git - karo-tx-linux.git/commit
rtc-add-support-for-spi-rtc-rx4581-checkpatch-fixes
authorAndrew Morton <akpm@linux-foundation.org>
Thu, 7 Feb 2013 01:27:49 +0000 (12:27 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Mon, 18 Feb 2013 05:47:18 +0000 (16:47 +1100)
commit6a12887aa69f36d63d473544b3a5c6964b3980e5
treea37aad70fb0ff7a03d4b7327797e41f329c4a108
parente37e7fe0c70120c941779cdf4be9d6feae725c85
rtc-add-support-for-spi-rtc-rx4581-checkpatch-fixes

WARNING: quoted string split across lines
#171: FILE: drivers/rtc/rtc-rx4581.c:126:
+ dev_err(dev, "Unable to write device "
+ "flags\n");

WARNING: quoted string split across lines
#214: FILE: drivers/rtc/rtc-rx4581.c:169:
+ dev_dbg(dev, "%s: tm is secs=%d, mins=%d, hours=%d, "
+ "mday=%d, mon=%d, year=%d, wday=%d\n",

WARNING: quoted string split across lines
#233: FILE: drivers/rtc/rtc-rx4581.c:188:
+ dev_dbg(dev, "%s: secs=%d, mins=%d, hours=%d, "
+ "mday=%d, mon=%d, year=%d, wday=%d\n",

WARNING: Using __devinit is unnecessary
#310: FILE: drivers/rtc/rtc-rx4581.c:265:
+static int __devinit rx4581_probe(struct spi_device *spi)

WARNING: Using __devexit is unnecessary
#329: FILE: drivers/rtc/rtc-rx4581.c:284:
+static int __devexit rx4581_remove(struct spi_device *spi)

WARNING: space prohibited between function name and open parenthesis '('
#355: FILE: drivers/rtc/rtc-rx4581.c:310:
+MODULE_DESCRIPTION ("rx4581 spi RTC driver");

WARNING: space prohibited between function name and open parenthesis '('
#356: FILE: drivers/rtc/rtc-rx4581.c:311:
+MODULE_AUTHOR ("Torben Hohn");

WARNING: space prohibited between function name and open parenthesis '('
#357: FILE: drivers/rtc/rtc-rx4581.c:312:
+MODULE_LICENSE ("GPL");

total: 0 errors, 8 warnings, 334 lines checked

./patches/rtc-add-support-for-spi-rtc-rx4581.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Torben Hohn <torbenh@linutronix.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/rtc/rtc-rx4581.c