]> git.karo-electronics.de Git - karo-tx-linux.git/commit
iscsi-target: Fix incorrect buffer usage in non-leading connection login
authorNicholas Bellinger <nab@linux-iscsi.org>
Thu, 29 May 2014 19:36:43 +0000 (12:36 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Thu, 29 May 2014 20:08:26 +0000 (13:08 -0700)
commit6ac1564eaf22f6020e16fef557c423e3c3c50f64
tree25b1b1cd271943d252ef69dc3c682c7a6f1c22c0
parent3936fed73039761a54d756010bcf39925224797b
iscsi-target: Fix incorrect buffer usage in non-leading connection login

This patch fixes a bug in non-leading connection login processing where
iscsi_login_non_zero_tsih_s2() was incorrectly using the login request
header as a temporary buffer for setting TargetPortalGroupTag.

This bug was manifesting itself as login failures with non-leading login
requests in multiple connection per session (MC/S) operation, and has
been present since the initial v3.1 merge of iscsi-target code.

However, the bug has only been able to trigger since the v3.10 changes
in commit baa4d64b1 where included to support iser-target.

Reported-by: Santosh Kulkarni <santosh.kulkarni@calsoftinc.com>
Cc: stable@vger.kernel.org # 3.1+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/iscsi/iscsi_target_login.c