]> git.karo-electronics.de Git - karo-tx-linux.git/commit
[SCSI] arcmsr: fix misuse of | instead of &
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 9 Jun 2012 09:10:19 +0000 (12:10 +0300)
committerJames Bottomley <JBottomley@Parallels.com>
Fri, 20 Jul 2012 07:58:31 +0000 (08:58 +0100)
commit6ad819b06ddf13a5a1d995eb26555903f6c3b71a
tree0464ebec1ee3af86517afff5911fb91897b03b58
parent23f0bb47a4ec4c662b2bbf0221d6289e91b06ece
[SCSI] arcmsr: fix misuse of | instead of &

ARCMSR_ARC1880_DiagWrite_ENABLE is 0x00000080 so (x | 0x00000080) is
never zero.  The intent here was to test that loop until
ARCMSR_ARC1880_DiagWrite_ENABLE was turned on, but because the test was
wrong, we would do five loops regardless of whether it succeed or not.

Also I simplified the condition a little by removing the unused
assignement.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Nick Cheng <nick.cheng@areca.com.tw>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/arcmsr/arcmsr_hba.c