]> git.karo-electronics.de Git - karo-tx-linux.git/commit
m68k/math-emu: unsigned issue, 'unsigned long' will never be less than zero
authorChen Gang <gang.chen@asianux.com>
Thu, 30 May 2013 08:21:36 +0000 (16:21 +0800)
committerGeert Uytterhoeven <geert@linux-m68k.org>
Fri, 31 May 2013 08:46:30 +0000 (10:46 +0200)
commit6b4ed65d28a54aa4e00a2ff54a2087cdd9f840f7
tree48e924ddc767b64e01549b7c03c700d74f6ddc03
parent7ee278258b342c6a7e9249666453096d2c04457b
m68k/math-emu: unsigned issue, 'unsigned long' will never be less than zero

'oldmant.m32[1]' is 'unsigned long' which can never be '< 0', and the
original author wanted to check whether the highest bit is set.

So make the bit test explicit (which is better than casting from 'unsigned
long' to 'long').

The related warning: (with EXTRA_CFLAGS=-W ARCH=m68k for allmodconfig)
  arch/m68k/math-emu/fp_arith.c:522:4: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]

Signed-off-by: Chen Gang <gang.chen@asianux.com>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
arch/m68k/math-emu/fp_arith.c