]> git.karo-electronics.de Git - karo-tx-linux.git/commit
staging: comedi: dt282x: dt282x_ai_insn_read() always fails
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 20 Aug 2013 08:57:35 +0000 (11:57 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Sep 2013 00:18:05 +0000 (17:18 -0700)
commit6b844e7d601f709942cf15e5f5808953f5382402
treeff61af0d0ddb90b5ae50611ff04d9d948a1de337
parent979ad974d2d7d1e98e21b582a11acdf0713914e6
staging: comedi: dt282x: dt282x_ai_insn_read() always fails

commit 2c4283ca7cdcc6605859c836fc536fcd83a4525f upstream.

In dt282x_ai_insn_read() we call this macro like:
wait_for(!mux_busy(), comedi_error(dev, "timeout\n"); return -ETIME;);
Because the if statement doesn't have curly braces it means we always
return -ETIME and the function never succeeds.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/dt282x.c