]> git.karo-electronics.de Git - karo-tx-linux.git/commit
can: Fix SJA1000 command register writes on SMP systems
authorOliver Hartkopp <socketcan@hartkopp.net>
Tue, 18 May 2010 21:03:10 +0000 (14:03 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 5 Jul 2010 18:15:46 +0000 (11:15 -0700)
commit6bf0eb89c2aa017d5b9d5a859e53cf9c39fd92c3
treee5ceb9ea3a977ffcb9d28325d64637f8322d1e6e
parent753a8491d6ccd145632d74e690391b0be3edd76b
can: Fix SJA1000 command register writes on SMP systems

commit 57c8a456640fa3ca777652f11f2db4179a3e66b6 upstream.

The SJA1000 command register is concurrently written in the rx-path to free
the receive buffer _and_ in the tx-path to start the transmission.

The SJA1000 data sheet, 6.4.4 COMMAND REGISTER (CMR) states:
"Between two commands at least one internal clock cycle is needed in
order to proceed. The internal clock is half of the external oscillator
frequency."

On SMP systems the current implementation leads to a write stall in the
tx-path, which can be solved by adding some general locking and some time
to settle the write_reg() operation for the command register.

Thanks to Klaus Hitschler for the original fix and detailed problem
description.

This patch applies on net-2.6 and (with some offsets) on net-next-2.6 .

Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Acked-by: Wolfgang Grandegger <wg@grandegger.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/can/sja1000/sja1000.c
drivers/net/can/sja1000/sja1000.h