]> git.karo-electronics.de Git - linux-beck.git/commit
PCI: Support PCIe Capability Slot registers only for ports with slots
authorBjorn Helgaas <bhelgaas@google.com>
Wed, 28 Aug 2013 18:01:03 +0000 (12:01 -0600)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 29 Aug 2013 02:51:39 +0000 (20:51 -0600)
commit6d3a1741f1e648cfbd5a0cc94477a0d5004c6f5e
tree07479c9db0957162e0b4c7a80be46361152a6838
parentc8b303d0206b28c4ff3aecada47108d1655ae00f
PCI: Support PCIe Capability Slot registers only for ports with slots

Previously we allowed callers to access Slot Capabilities, Status, and
Control for Root Ports even if the Root Port did not implement a slot.
This seems dubious because the spec only requires these registers if a
slot is implemented.

It's true that even Root Ports without slots must have *space* for these
slot registers, because the Root Capabilities, Status, and Control
registers are after the slot registers in the capability.  However,
for a v1 PCIe Capability, the *semantics* of the slot registers are
undefined unless a slot is implemented.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-By: Jiang Liu <jiang.liu@huawei.com>
drivers/pci/access.c