]> git.karo-electronics.de Git - karo-tx-linux.git/commit
usb: gadget: pch_udc: Fix wrong return value
authorTomoya MORINAGA <tomoya.rohm@gmail.com>
Thu, 12 Jan 2012 02:27:06 +0000 (11:27 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 22 Apr 2012 23:21:42 +0000 (16:21 -0700)
commit6ec7b0ee0b557e05d07d0f4530e6d04bc0ad5e81
tree14402f99a966b2035e5915e6758a6235baf133fa
parent21c7c5809c9d11ad3c1cdba9f0935b97ae4ccdd3
usb: gadget: pch_udc: Fix wrong return value

commit c802672cd36cd063bfd54d54c8c34825ab5b2357 upstream.

ISSUE:
If the return value of pch_udc_pcd_init() is False, the return value of
this function is unsettled.
Since pch_udc_pcd_init() always returns 0, there is not actually the issue.

CAUSE:
If pch_udc_pcd_init() is True, the variable, retval, is not set for an
appropriate value.

Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/pch_udc.c