]> git.karo-electronics.de Git - linux-beck.git/commit
staging: IIO: Fix uses of spinlocks prior to init in ring implementations
authorJonathan Cameron <jic23@cam.ac.uk>
Tue, 2 Mar 2010 13:35:35 +0000 (13:35 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 11 May 2010 18:35:32 +0000 (11:35 -0700)
commit6f2dfb3101bb431ae9adc827fa8526d699e9dbd0
tree8d94b43bf5855ed8d240b6183cff6ffbc5f71c6b
parent3e18951955797872558dad615851a4ca63b2770e
staging: IIO: Fix uses of spinlocks prior to init in ring implementations

Some confusion was caused by the ___iio_init_ring_buffer and equivalent
in ring_sw handling both init of spin locks etc and allocation and
of the actual buffer.  This resulted in ring->use_lock being held
before it was initialized and actually during the initialization.

Some of the recent cleanups in the spin lock code seem to have triggered
the bug actually causing traceable crashes.

The following patch should fix this but hasn't been extensively tested
as of yet and there may well be some side effects I haven't thought of.
Just wanted to get this out there before anyone else runs into it!

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/iio/industrialio-ring.c
drivers/staging/iio/ring_generic.h
drivers/staging/iio/ring_sw.c