]> git.karo-electronics.de Git - karo-tx-linux.git/commit
batman-adv: fix skb->data assignment
authorAntonio Quartulli <ordex@autistici.org>
Fri, 29 Jun 2012 20:58:03 +0000 (22:58 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 4 Jul 2012 04:44:21 +0000 (05:44 +0100)
commit6f4d747dfba5228b6041a9637fa0d944922ce72c
treeab3b6bfc24e371940d9ebf148b81daae7d736d3a
parent4c42ad8fcf33fee7b949a6355b71a773843131b9
batman-adv: fix skb->data assignment

commit 2c995ff892313009e336ecc8ec3411022f5b1c39 upstream.

skb_linearize(skb) possibly rearranges the skb internal data and then changes
the skb->data pointer value. For this reason any other pointer in the code that
was assigned skb->data before invoking skb_linearise(skb) must be re-assigned.

In the current tt_query message handling code this is not done and therefore, in
case of skb linearization, the pointer used to handle the packet header ends up
in pointing to free'd memory.

This bug was introduced by a73105b8d4c765d9ebfb664d0a66802127d8e4c7
(batman-adv: improved client announcement mechanism)

Signed-off-by: Antonio Quartulli <ordex@autistici.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
[This patch is a backport for kernel versions 3.1 and 3.2 - Antonio]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/batman-adv/routing.c