]> git.karo-electronics.de Git - karo-tx-linux.git/commit
NFS/sunrpc: don't use a credential with extra groups.
authorNeilBrown <neilb@suse.de>
Mon, 24 Oct 2011 23:25:49 +0000 (10:25 +1100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 11 Nov 2011 17:37:07 +0000 (09:37 -0800)
commit6fa9e3e3e01b8741eead6e00bb968ef3b4fddc3f
tree64cbc64a7b8de5b4958e08cc7891e20997c6ea76
parent22bef71b2e411ee05b9b9199394c3a209924926f
NFS/sunrpc: don't use a credential with extra groups.

commit dc6f55e9f8dac4b6479be67c5c9128ad37bb491f upstream.

The sunrpc layer keeps a cache of recently used credentials and
'unx_match' is used to find the credential which matches the current
process.

However unx_match allows a match when the cached credential has extra
groups at the end of uc_gids list which are not in the process group list.

So if a process with a list of (say) 4 group accesses a file and gains
access because of the last group in the list, then another process
with the same uid and gid, and a gid list being the first tree of the
gids of the original process tries to access the file, it will be
granted access even though it shouldn't as the wrong rpc credential
will be used.

Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/sunrpc/auth_unix.c