]> git.karo-electronics.de Git - karo-tx-linux.git/commit
[media] radio-si470x-usb: remove autosuspend, implement suspend/resume
authorHans Verkuil <hans.verkuil@cisco.com>
Fri, 4 May 2012 12:42:29 +0000 (09:42 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 14 May 2012 16:45:44 +0000 (13:45 -0300)
commit6fd522a6d12d0ebac528f2d4553c4bf51c0c3275
treed4fffc048e45264f848903dfb8bec83ff0d3598e
parent340bd4c16cead8bf8f5205c7d283a3bd9d699f76
[media] radio-si470x-usb: remove autosuspend, implement suspend/resume

The radio-si470x-usb driver supported both autosuspend and it stopped the
radio the moment the last user of the radio device closed it. However, that
was very confusing since if you play the audio from the device (e.g. through
arecord -D ... | aplay) then no sound would play unless you had the radio
device open at the same time, even though there is no need to do anything
with that node.

On the other hand, the actual suspend/resume functions didn't do anything,
which would fail if you *did* have the radio node open at that time.

So:

- remove autosuspend (bad idea in general for USB radio devices)
- move the start/stop out of the open/release functions into the resume/suspend
  functions.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Tobias Lorenz <tobias.lorenz@gmx.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/radio/si470x/radio-si470x-common.c
drivers/media/radio/si470x/radio-si470x-usb.c