]> git.karo-electronics.de Git - linux-beck.git/commit
staging: comedi: mite: remove BUG_ON() in MITE_IODWBSR_1_WSIZE_bits()
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Wed, 20 Apr 2016 17:36:42 +0000 (10:36 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 29 Apr 2016 05:18:51 +0000 (22:18 -0700)
commit7024cc88bf80644c50d125a47ae5ab6b7f675216
treedb4465feb965faec0baa2376976bb56532b8b68a
parent43d667243c734fe7de39a586a095ea8fec9a873a
staging: comedi: mite: remove BUG_ON() in MITE_IODWBSR_1_WSIZE_bits()

Prior to calling this function pci_ioremap_bar() is called. If the
pci_resource_len(), i.e. the 'size', was 0 the ioremap would fail
so this function would never be called. So the first BUG_ON() can
never occur.

The 'order' returned by ilog2() will always be > 0 so the second
BUG_ON() will also never occur.

Remove the unnecessary BUG_ON() checks and tidy up the function.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/mite.c