]> git.karo-electronics.de Git - karo-tx-linux.git/commit
greybus: audio: fix uninitialized variable errors found by cppcheck
authorVaibhav Agarwal <vaibhav.sr@gmail.com>
Sat, 24 Sep 2016 17:36:26 +0000 (23:06 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Sep 2016 10:59:51 +0000 (12:59 +0200)
commit7224a2a50a29871b2ae04cac731ea199adedbe68
tree69721edc1ee044dc345626e37d0b3458d56dfc65
parentdc258c15ea121414277156511c8cca944443201e
greybus: audio: fix uninitialized variable errors found by cppcheck

Currently, if info is null, the dev_err message is dereferencing an
uninitialized module pointer.  Instead, it should use codec->dev pointer
in dev_err call and better align with other err msg in this function.

Also, ret variable might be used uninitialized in a specific case.
Avoid using it this way.

Found using static analysis with cppcheck:
Checking drivers/staging/greybus/audio_topology.c...
[drivers/staging/greybus/audio_topology.c:175]: (error) Uninitialized
variable: module
[drivers/staging/greybus/audio_topology.c:495]: (error) Uninitialized
variable: ret

Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/greybus/audio_topology.c