]> git.karo-electronics.de Git - karo-tx-linux.git/commit
scsi/libiscsi: Fix static checker warning on bh locking
authorShlomo Pongratz <shlomop@mellanox.com>
Sun, 30 Mar 2014 12:26:29 +0000 (15:26 +0300)
committerChristoph Hellwig <hch@lst.de>
Mon, 19 May 2014 11:33:00 +0000 (13:33 +0200)
commit72b9740201d5f0e24b0b8326a4949786a30ff628
treee74603446a6e204dc3b9906cd41bbd3275102fe7
parentabb14148c0f850e7201efc3e7aea1762f993606b
scsi/libiscsi: Fix static checker warning on bh locking

Commit 659743b "[SCSI] libiscsi: Reduce locking contention in fast path" introduced a
new smatch warning on libiscsi.c "iscsi_xmit_task() warn: inconsistent returns
bottom_half:: locked (1410 [(-61)]) unlocked (1425 [0], 1425 [s32min-(-1),1-s32max])",
which we can eliminate by using non bh locking on the nested spin_lock call.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Shlomo Pongratz <shlomop@mellanox.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/scsi/libiscsi.c