]> git.karo-electronics.de Git - karo-tx-linux.git/commit
drm/plane-helper: Add drm_plane_helper_check_update() (v3)
authorMatt Roper <matthew.d.roper@intel.com>
Thu, 29 May 2014 15:06:52 +0000 (08:06 -0700)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 3 Jun 2014 14:36:01 +0000 (16:36 +0200)
commit72d6285291ba0c517c39ef7b6aebaf22db3ace3b
tree55ff0670aef538135f7cb884f95a7cbd3b0eab07
parent177331d5482868e244e794ee410137512b889cf1
drm/plane-helper: Add drm_plane_helper_check_update() (v3)

Pull the parameter checking from drm_primary_helper_update() out into
its own function; drivers that provide their own setplane()
implementations rather than using the helper may still want to share
this parameter checking logic.

A few of the checks here were also updated based on suggestions by
Ville Syrjälä.

v3:
 - s/primary_helper/plane_helper/ --- this checking logic may be useful
   for other types of planes as well.
 - Fix visibility check (need to dereference visibility pointer)
v2:
 - Pass src/dest/clip rects and min/max scaling down to helper to avoid
   duplication of effort between helper and drivers (suggested by
   Ville).
 - Allow caller to specify whether the primary plane should be
   updatable while the crtc is disabled.

Cc: dri-devel@lists.freedesktop.org
Reviewed-by: Chon Ming Lee <chon.ming.lee@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Acked-by: Dave Airlie <airlied@gmail.com>
[danvet: Include header properly and fixup declaration mismatch to
make this compile.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/drm_plane_helper.c
include/drm/drm_plane_helper.h