]> git.karo-electronics.de Git - linux-beck.git/commit
tpm_crb: fix crb_req_canceled behavior
authorJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Fri, 2 Sep 2016 19:34:17 +0000 (22:34 +0300)
committerJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Thu, 15 Sep 2016 13:04:21 +0000 (16:04 +0300)
commit72fd50e14e46dc0edf360631bdece87c2f066a97
tree6a4d066f4669c8833f37da1dbed27ac65e2221fc
parent0c541332231e7957f23013e37f3720db33e7804c
tpm_crb: fix crb_req_canceled behavior

The req_canceled() callback is used by tpm_transmit() periodically to
check whether the request has been canceled while it is receiving a
response from the TPM.

The TPM_CRB_CTRL_CANCEL register was cleared already in the crb_cancel
callback, which has two consequences:

* Cancel might not happen.
* req_canceled() always returns zero.

A better place to clear the register is when starting to send a new
command. The behavior of TPM_CRB_CTRL_CANCEL is described in the
section 5.5.3.6 of the PTP specification.

CC: stable@vger.kernel.org
Fixes: 30fc8d138e91 ("tpm: TPM 2.0 CRB Interface")
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
drivers/char/tpm/tpm_crb.c