]> git.karo-electronics.de Git - linux-beck.git/commit
staging: wilc1000: simplify vif[i]->ndev accesses
authorArnd Bergmann <arnd@arndb.de>
Wed, 16 Nov 2016 15:07:10 +0000 (16:07 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Nov 2016 17:30:22 +0000 (18:30 +0100)
commit735bb39ca3bed8469b3b3a42d8cc57bdb9fc4dd7
treec758ef8c99674b53bc952a425eaf7daaea73ade9
parent2c52b1efd6937e492863deb2485fdebddf5d7223
staging: wilc1000: simplify vif[i]->ndev accesses

With gcc-7, I got a new warning for this driver:

wilc1000/linux_wlan.c: In function 'wilc_netdev_cleanup':
wilc1000/linux_wlan.c:1224:15: error: 'vif[1]' may be used uninitialized in this function [-Werror=maybe-uninitialized]
wilc1000/linux_wlan.c:1224:15: error: 'vif[0]' may be used uninitialized in this function [-Werror=maybe-uninitialized]

A closer look at the function reveals that it's more complex than
it needs to be, given that based on how the device is created
we always get

netdev_priv(vif->ndev) == vif

Based on this assumption, I found a few other places in the same file
that can be simplified. That code appears to be a relic from times
when the assumption above was not valid.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wilc1000/linux_wlan.c