]> git.karo-electronics.de Git - karo-tx-linux.git/commit
net/fec: Don't let ndo_start_xmit return NETDEV_TX_BUSY without link
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tue, 30 Jul 2013 09:29:40 +0000 (11:29 +0200)
committerJason Liu <r64343@freescale.com>
Wed, 30 Oct 2013 01:54:22 +0000 (09:54 +0800)
commit737420d568a1106b81d6491ca80080f42f0ac69d
tree5a27e20ecb2d33da184622fad68c70e6157dbd2e
parent0c5162a1ada5732d599f96bfc9c5d20a81e20e34
net/fec: Don't let ndo_start_xmit return NETDEV_TX_BUSY without link

Don't test for having link and let hardware deal with this situation.

Without this patch I see a machine running an -rt patched Linux being
stuck in sch_direct_xmit when it looses link while there is still a
packet to be sent. In this case the fec_enet_start_xmit routine returned
NETDEV_TX_BUSY which makes the network stack reschedule the packet and
so sch_direct_xmit calls fec_enet_start_xmit again.
I failed to reproduce a complete hang without -rt, but I think the
problem exists there, too.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/fec_main.c