]> git.karo-electronics.de Git - linux-beck.git/commit
powerpc/eeh: Fix wrong flag passed to eeh_unfreeze_pe()
authorGavin Shan <gwshan@linux.vnet.ibm.com>
Wed, 18 Jan 2017 23:10:16 +0000 (10:10 +1100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Feb 2017 07:08:27 +0000 (08:08 +0100)
commit73d45909780e7f8632cbc58971c84a67a8622c7a
tree334dd2c0ad5b00e6d0f5c63f0da7955e23bbdc31
parent4b70d598c2ee1f47871ba12db832fcbbb4adb491
powerpc/eeh: Fix wrong flag passed to eeh_unfreeze_pe()

commit f05fea5b3574a5926c53865eea27139bb40b2f2b upstream.

In __eeh_clear_pe_frozen_state(), we should pass the flag's value
instead of its address to eeh_unfreeze_pe(). The isolated flag is
cleared if no error returned from __eeh_clear_pe_frozen_state(). We
never observed the error from the function. So the isolated flag should
have been always cleared, no real issue is caused because of the misused
@flag.

This fixes the code by passing the value of @flag to eeh_unfreeze_pe().

Fixes: 5cfb20b96f6 ("powerpc/eeh: Emulate EEH recovery for VFIO devices")
Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/powerpc/kernel/eeh_driver.c