]> git.karo-electronics.de Git - karo-tx-linux.git/commit
hostap_cs: fix sleeping function called from invalid context
authorStanislaw Gruszka <sgruszka@redhat.com>
Mon, 10 Jan 2011 11:56:05 +0000 (12:56 +0100)
committerAK <andi@firstfloor.org>
Thu, 31 Mar 2011 18:57:53 +0000 (11:57 -0700)
commit755fc62c61ab748285ef5940f6a7c9b93f1b70b8
tree70ee6a73299452bb44035283a91848a71a4de3bc
parente9873656fb0e28d4f5f461a990e4885e2a01f947
hostap_cs: fix sleeping function called from invalid context

commit 4e5518ca53be29c1ec3c00089c97bef36bfed515 upstream.

pcmcia_request_irq() and pcmcia_enable_device() are intended
to be called from process context (first function allocate memory
with GFP_KERNEL, second take a mutex). We can not take spin lock
and call them.

It's safe to move spin lock after pcmcia_enable_device() as we
still hold off IRQ until dev->base_addr is 0 and driver will
not proceed with interrupts when is not ready.

Patch resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=643758

Reported-and-tested-by: rbugz@biobind.com
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
drivers/net/wireless/hostap/hostap_cs.c