]> git.karo-electronics.de Git - karo-tx-linux.git/commit
drivers/net/wireless/p54/eeprom.c: Return -ENOMEM on memory allocation failure
authorJulia Lawall <julia@diku.dk>
Fri, 15 Oct 2010 13:00:06 +0000 (15:00 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 22 Nov 2010 18:47:35 +0000 (10:47 -0800)
commit7577c943f913d95b797c5bcd9862c47a06bbdb66
treeb366238a7bee634372adbccaae03189544ef52a8
parent735a3742bb8705f71d185d16ef2a9b1ee156003a
drivers/net/wireless/p54/eeprom.c: Return -ENOMEM on memory allocation failure

commit 0d91f22b75347d9503b17a42b6c74d3f7750acd6 upstream.

In this code, 0 is returned on memory allocation failure, even though other
failures return -ENOMEM or other similar values.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression ret;
expression x,e1,e2,e3;
@@

ret = 0
... when != ret = e1
*x = \(kmalloc\|kcalloc\|kzalloc\)(...)
... when != ret = e2
if (x == NULL) { ... when != ret = e3
  return ret;
}
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Christian Lamparter <chunkeey@googlemail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/wireless/p54/eeprom.c