]> git.karo-electronics.de Git - karo-tx-linux.git/commit
fuse: fix permission checking
authorMiklos Szeredi <mszeredi@suse.cz>
Sat, 23 Feb 2008 23:23:27 +0000 (15:23 -0800)
committerChris Wright <chrisw@sous-sol.org>
Mon, 24 Mar 2008 18:47:13 +0000 (11:47 -0700)
commit759be208409db44bdc81bd28156c38e4f9501ecd
treea928417d7383000a5616134a62a83397d5872b8d
parent7c0f76561fdc0a24ebfae4ee4112d62473eb3bdc
fuse: fix permission checking

[upstream commit 1a823ac9ff09cbdf39201df37b7ede1f9395de83]

I added a nasty local variable shadowing bug to fuse in 2.6.24, with the
result, that the 'default_permissions' mount option is basically ignored.

How did this happen?

 - old err declaration in inner scope
 - new err getting declared in outer scope
 - 'return err' from inner scope getting removed
 - old declaration not being noticed

-Wshadow would have saved us, but it doesn't seem practical for
the kernel :(

More testing would have also saved us :((

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/fuse/dir.c