]> git.karo-electronics.de Git - karo-tx-linux.git/commit
of/platform: Fix of_platform_device_destroy iteration of devices
authorGrant Likely <grant.likely@linaro.org>
Tue, 24 Jun 2014 15:13:47 +0000 (16:13 +0100)
committerGrant Likely <grant.likely@linaro.org>
Mon, 7 Jul 2014 12:33:46 +0000 (13:33 +0100)
commit75f353b61342b5847c7f6d8499fd6301dce09845
tree39181c9145ae4a6625128a9b81ebbac2011429eb
parentcd3de83f147601356395b57a8673e9c5ff1e59d1
of/platform: Fix of_platform_device_destroy iteration of devices

of_platform_destroy does not work properly, since the tree
population test was iterating on all devices having as its parent
the given platform device.

The check was intended to check whether any other platform or amba
devices created by of_platform_populate were still populated, but
instead checked for every kind of device. This is wrong, since platform
devices typically create a subsystem regular device and set themselves
as parents.

Instead, go ahead and call the unregister functions for any devices
created with of_platform_populate. The driver core will take care of
unbinding drivers, and drivers are responsible for getting rid of any
child devices that weren't created by of_platform_populate.

Signed-off-by: Grant Likely <grant.likely@linaro.org>
Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
drivers/of/platform.c
include/linux/of.h
include/linux/of_platform.h