]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ALSA: pxa27x: fix ac97 cold reset
authorMike Dunn <mikedunn@newsguy.com>
Mon, 7 Jan 2013 21:55:12 +0000 (13:55 -0800)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 6 Feb 2013 04:33:26 +0000 (04:33 +0000)
commit762a4af818aeee9566231ae627694743ec168380
treef3bf3e9711ec9787fe21b03a4161494d7f427a66
parent31980f8fa9e57f23b301e91dfa79f7f5c517233d
ALSA: pxa27x: fix ac97 cold reset

commit 41b645c8624df6ace020a8863ad1449d69140f7d upstream.

Cold reset on the pxa27x currently fails and

     pxa2xx_ac97_try_cold_reset: cold reset timeout (GSR=0x44)

appears in the kernel log.  Through trial-and-error (the pxa270 developer's
manual is mostly incoherent on the topic of ac97 reset), I got cold reset to
complete by setting the WARM_RST bit in the GCR register (and later noticed that
pxa3xx does this for cold reset as well).  Also, a timeout loop is needed to
wait for the reset to complete.

Tested on a palm treo 680 machine.

Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
Acked-by: Igor Grinberg <grinberg@compulab.co.il>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
sound/arm/pxa2xx-ac97-lib.c