]> git.karo-electronics.de Git - linux-beck.git/commit
scsi: qla2xxx: Avoid that issuing a LIP triggers a kernel crash
authorMauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>
Thu, 26 Jan 2017 00:07:06 +0000 (22:07 -0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Feb 2017 23:25:39 +0000 (15:25 -0800)
commit76a9ac048b4876849b6e95fa4b20cca949f2bf0a
treec0767b5bdbf4cc2402e00011047c774c7287c3e2
parentb5d5f2877c8d447f56a9b5477e485e6361fcd2d3
scsi: qla2xxx: Avoid that issuing a LIP triggers a kernel crash

commit 2780f3c8f0233de90b6b47a23fc422b7780c5436 upstream.

Avoid that issuing a LIP as follows:

  find /sys -name 'issue_lip'|while read f; do echo 1 > $f; done

triggers the following:

BUG: unable to handle kernel NULL pointer dereference at (null)
Call Trace:
 qla2x00_abort_all_cmds+0xed/0x140 [qla2xxx]
 qla2x00_abort_isp_cleanup+0x1e3/0x280 [qla2xxx]
 qla2x00_abort_isp+0xef/0x690 [qla2xxx]
 qla2x00_do_dpc+0x36c/0x880 [qla2xxx]
 kthread+0x10c/0x140

[mkp: consolidated Mauricio's and Bart's fixes]

Signed-off-by: Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>
Reported-by: Bart Van Assche <bart.vanassche@sandisk.com>
Fixes: 1535aa75a3d8 ("qla2xxx: fix invalid DMA access after command aborts in PCI device remove")
Cc: Himanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/qla2xxx/qla_os.c