]> git.karo-electronics.de Git - linux-beck.git/commit
brcmfmac: fix pmksa->bssid usage
authorNicolas Iooss <nicolas.iooss_linux@m4x.org>
Tue, 23 Aug 2016 09:37:17 +0000 (11:37 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Sat, 3 Sep 2016 17:02:03 +0000 (20:02 +0300)
commit7703773ef1d85b40433902a8da20167331597e4a
tree33ff4571dfacab44ec1565d1662389acb0780c1c
parentbccf3ffc8c6d8e0251a15541bb4d12b423c4f729
brcmfmac: fix pmksa->bssid usage

The struct cfg80211_pmksa defines its bssid field as:

    const u8 *bssid;

contrary to struct brcmf_pmksa, which uses:

    u8 bssid[ETH_ALEN];

Therefore in brcmf_cfg80211_del_pmksa(), &pmksa->bssid takes the address
of this field (of type u8**), not the one of its content (which would be
u8*).  Remove the & operator to make brcmf_dbg("%pM") and memcmp()
behave as expected.

This bug have been found using a custom static checker (which checks the
usage of %p... attributes at build time).  It has been introduced in
commit 6c404f34f2bd ("brcmfmac: Cleanup pmksa cache handling code"),
which replaced pmksa->bssid by &pmksa->bssid while refactoring the code,
without modifying struct cfg80211_pmksa definition.

Replace &pmk[i].bssid with pmk[i].bssid too to make the code clearer,
this change does not affect the semantic.

Fixes: 6c404f34f2bd ("brcmfmac: Cleanup pmksa cache handling code")
Cc: stable@vger.kernel.org
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c