]> git.karo-electronics.de Git - karo-tx-linux.git/commit
staging: comedi: addi_apci_1564: remove private data 'mode_select_register'
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Fri, 24 Oct 2014 17:26:05 +0000 (10:26 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Oct 2014 08:06:01 +0000 (16:06 +0800)
commit7885b070b83ce5c8fb42bf65047e7dd6388d7b20
tree2ddbbace76bc0950fd091bb660893fc2b7b05b29
parent367ff14edd97bbd0d54e5bdfeb10201cbe491d0b
staging: comedi: addi_apci_1564: remove private data 'mode_select_register'

This driver currently passes the timer channel as the data[5] element to the
timer (*insn_config) function. This is stored in the private data and use in
the timer (*insn_read) and (*insn_write) functions to read/write the timer.

This is just wrong, comedi passes the channel number in the insn->chanspec.
Use that instead and remove the private data member.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
drivers/staging/comedi/drivers/addi_apci_1564.c