]> git.karo-electronics.de Git - karo-tx-linux.git/commit
memory hotplug: suppress "Device nodeX does not have a release() function" warning
authorYasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Thu, 25 Oct 2012 01:14:47 +0000 (12:14 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Mon, 29 Oct 2012 03:17:20 +0000 (14:17 +1100)
commit78b77b3aab3fbe419a352bac3ab81a2981c9cde1
treebf148614b8a0b5ccc2300bea22e1a9edb2ec4f01
parentc5d2e39fda39a1014ccff793db34c7b116923eec
memory hotplug: suppress "Device nodeX does not have a release() function" warning

When calling unregister_node(), the function shows following message at
device_release().

"Device 'node2' does not have a release() function, it is broken and must
be fixed."

The reason is node's device struct does not have a release() function.

So the patch registers node_device_release() to the device's release()
function for suppressing the warning message.  Additionally, the patch
adds memset() to initialize a node struct into register_node().  Because
the node struct is part of node_devices[] array and it cannot be freed by
node_device_release().  So if system reuses the node struct, it has a
garbage.

Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
Acked-by: David Rientjes <rientjes@google.com>
Cc: Jiang Liu <liuj97@gmail.com>
Cc: Minchan Kim <minchan.kim@gmail.com>
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/base/node.c