]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ALSA: usb-audio: Fix races at disconnection
authorTakashi Iwai <tiwai@suse.de>
Wed, 7 Nov 2012 11:42:44 +0000 (12:42 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 17 Nov 2012 21:16:12 +0000 (13:16 -0800)
commit799c92f2aecb348e4a4c6dab80c7206e48caf201
treeec6b68e06d20857141fa4db80b1b76d74b453d56
parent5fee99c200f8138f3eb1cd6b3d69b199b3d86686
ALSA: usb-audio: Fix races at disconnection

commit 978520b75f0a1ce82b17e1e8186417250de6d545 upstream.

Close some races at disconnection of a USB audio device by adding the
chip->shutdown_mutex and chip->shutdown check at appropriate places.

The spots to put bandaids are:
- PCM prepare, hw_params and hw_free
- where the usb device is accessed for communication or get speed, in
 mixer.c and others; the device speed is now cached in subs->speed
 instead of accessing to chip->dev

The accesses in PCM open and close don't need the mutex protection
because these are already handled in the core PCM disconnection code.

The autosuspend/autoresume codes are still uncovered by this patch
because of possible mutex deadlocks.  They'll be covered by the
upcoming change to rwsem.

Also the mixer codes are untouched, too.  These will be fixed in
another patch, too.

Reported-by: Matthieu CASTET <matthieu.castet@parrot.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/usb/card.h
sound/usb/endpoint.c
sound/usb/mixer.c
sound/usb/pcm.c
sound/usb/proc.c