]> git.karo-electronics.de Git - karo-tx-linux.git/commit
[media] v4l: tvp5150: Don't override output pinmuxing at stream on/off time
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Fri, 9 Dec 2016 11:47:19 +0000 (09:47 -0200)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 21 Dec 2016 09:32:15 +0000 (07:32 -0200)
commit79d6205a3f741c9fb89cfc47dfa0eddb1526726d
tree86a59bd4baa9c879b39fc3d241a518102192c25a
parentb4b2de386bbb6589d81596999d4a924928dc119b
[media] v4l: tvp5150: Don't override output pinmuxing at stream on/off time

The s_stream() handler incorrectly writes the whole MISC_CTL register to
enable or disable the outputs, overriding the output pinmuxing
configuration. Fix it to only touch the output enable bits.

The CONF_SHARED_PIN register is also written by the same function,
resulting in muxing the INTREQ signal instead of the VBLK/GPCL signal on
the INTREQ/GPCL/VBLK pin. As the driver doesn't support interrupts this
is obviously incorrect, and breaks operation on other devices. Fix it by
removing the write.

Cc: stable@vger.kernel.org # For Kernel 4.5 and upper
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/i2c/tvp5150.c