]> git.karo-electronics.de Git - karo-tx-linux.git/commit
USB: Fix a bug on appledisplay.c regarding signedness
authorpancho horrillo <pancho@pancho.name>
Wed, 23 Dec 2009 10:09:13 +0000 (11:09 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 6 Jan 2010 22:26:33 +0000 (14:26 -0800)
commit79ec7f562e3d0a7a78697ce3031e648e5a4cbdc2
tree7af26120ed8d8b4df526521cd6db6038088d7abf
parent61a6c8ed6de9b2eb4c3f2850bbfb2e0aa9e182f0
USB: Fix a bug on appledisplay.c regarding signedness

commit 37e9066b2f85480d99d3795373f5ef0b00ac1189 upstream.

brightness status is reported by the Apple Cinema Displays as an
'unsigned char' (u8) value, but the code used 'char' instead.

Note that he driver was developed on the PowerPC architecture,
where the two types are synonymous, which is not always the case.

Fixed that.  Otherwise the driver will interpret brightness
levels > 127 as negative, and fail to load.

Signed-off-by: pancho horrillo <pancho@pancho.name>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/misc/appledisplay.c