]> git.karo-electronics.de Git - linux-beck.git/commit
[media] v4l2-ctrls: fix sparse warning
authorHans Verkuil <hans.verkuil@cisco.com>
Mon, 22 Sep 2014 14:08:55 +0000 (11:08 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Tue, 28 Oct 2014 18:32:52 +0000 (16:32 -0200)
commit7a7f1ab37dc8f66cf0ef10f3d3f1b79ac4bc67fc
tree43f8f442b3cbe747bccbbd4a31266b8b68f512a7
parentf9cc70bfa4ab40b95aa49e9e7e4bb166364d07e6
[media] v4l2-ctrls: fix sparse warning

The warning is simple:

drivers/media/v4l2-core/v4l2-ctrls.c:1685:15: warning: incorrect type in assignment (different address spaces)

but the fix isn't.

The core problem was that the conversion from user to kernelspace was
done at too low a level and that needed to be moved up. That made it possible
to drop pointers to v4l2_ext_control from set_ctrl and validate_new and
clean up this sparse warning because those functions now always operate
on kernelspace pointers.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/v4l2-core/v4l2-ctrls.c