]> git.karo-electronics.de Git - karo-tx-linux.git/commit
RTNETLINK: Fix bogus ASSERT_RTNL warning
authorPatrick McHardy <kaber@trash.net>
Thu, 24 Apr 2008 05:10:48 +0000 (22:10 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 1 May 2008 21:44:32 +0000 (14:44 -0700)
commit7b6f7f4d0fe48c84a499292947cc1bfcb74e6fc5
tree0642095c55e4e7fa9d9ec83ff31c56a45bd62f07
parente8a8637fe11a48ca358a8839bbe8ddb871cd30e1
RTNETLINK: Fix bogus ASSERT_RTNL warning

[ Upstream commit: c9c1014b2bd014c7ec037bbb6f58818162fdb265 ]

ASSERT_RTNL uses mutex_trylock to test whether the rtnl_mutex is
held. This bogus warnings when running in atomic context, which
f.e. happens when adding secondary unicast addresses through
macvlan or vlan or when synchronizing multicast addresses from
wireless devices.

Mid-term we might want to consider moving all address updates
to process context since the locking seems overly complicated,
for now just fix the bogus warning by changing ASSERT_RTNL to
use mutex_is_locked().

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
include/linux/rtnetlink.h
net/core/rtnetlink.c