]> git.karo-electronics.de Git - karo-tx-linux.git/commit
staging: comedi: ni_pcidio: prevent "empty acquisition" async command
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Tue, 9 Sep 2014 23:15:51 +0000 (16:15 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 11 Sep 2014 21:35:21 +0000 (14:35 -0700)
commit7be7f9c3e3f87fd1263014a14b177409b6542e54
treee3c6ef69c06c7fd6e4c994dc7eeb0693973449ef
parentfd6887b2ec985f7fcc42b48caa6561ed98cbf720
staging: comedi: ni_pcidio: prevent "empty acquisition" async command

This driver currently allows a cmd->stop_src == TRIG_COUNT with a cmd->stop_arg
of 0. The (*do_cmd) then sets up and starts the command without handling the "empty
acquisition". This results in the interrupt function trying to transfer 0 data
samples.

Validate that the cmd->stop_arg is >= 1 in the (*do_cmdtest) to prevent the
"empty acquisition".

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/ni_pcidio.c