]> git.karo-electronics.de Git - linux-beck.git/commit
drm/rockchip: Avoid race with vblank count increment
authorTomasz Figa <tfiga@chromium.org>
Wed, 14 Sep 2016 12:54:56 +0000 (21:54 +0900)
committerSean Paul <seanpaul@chromium.org>
Wed, 21 Sep 2016 13:55:50 +0000 (06:55 -0700)
commit7caecdbec1128a934ee628f399110dff8a50c9a1
tree55355d848a6b012feffbbb1b4296ab8c35eb0ec0
parent65bcb6bcc8b791ed9fa97603c2ed8063d41cedbe
drm/rockchip: Avoid race with vblank count increment

Since VOP does not have a hardware vblank count register, the ongoing
commit might be racing with a requested vblank interrupt, which would
increment the software vblank counter before the changes being committed
actually happen.

To avoid this, we can extend .atomic_flush(), so after it sets cfg_done
bit, it polls the vblank interrupt bit until it's inactive to make sure
that any old vblank interrupt gets to the handler and then uses
synchronize_irq(vop->irq) to make sure the handler finishes running.

The polling case should happen very rarely, but even if, the total wait
time should be relatively low and in practice almost equal to the vop
hardirq handler running time.

Signed-off-by: Tomasz Figa <tfiga@chromium.org>
drivers/gpu/drm/rockchip/rockchip_drm_vop.c