]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ext4: fix potential use after free in __ext4_journal_stop
authorLukas Czerner <lczerner@redhat.com>
Sun, 18 Oct 2015 02:55:19 +0000 (22:55 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Sun, 18 Oct 2015 02:55:19 +0000 (22:55 -0400)
commit7ce017a5ee53c2268f8c8355d0a87e74374020d7
tree83406bbb7e2efb93f1dea6a3eceeb81c37b01300
parent8ae1c852dfd384a36925d6d9d8fd675a7b95f184
ext4: fix potential use after free in __ext4_journal_stop

There is a use-after-free possibility in __ext4_journal_stop() in the
case that we free the handle in the first jbd2_journal_stop() because
we're referencing handle->h_err afterwards. This was introduced in
9705acd63b125dee8b15c705216d7186daea4625 and it is wrong. Fix it by
storing the handle->h_err value beforehand and avoid referencing
potentially freed handle.

Fixes: 9705acd63b125dee8b15c705216d7186daea4625
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Cc: stable@vger.kernel.org
fs/ext4/ext4_jbd2.c