]> git.karo-electronics.de Git - linux-beck.git/commit
bonding: Check return of dev_set_promiscuity/allmulti
authorWang Chen <wangchen@cn.fujitsu.com>
Tue, 15 Jul 2008 03:51:36 +0000 (20:51 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 15 Jul 2008 03:51:36 +0000 (20:51 -0700)
commit7e1a1ac1fbaa88fe254400b7f30b775502932ad3
tree5084fc1e90687cdec4ad62cd1ae81b75e6efe765
parent2aeb0b88b3c7a0e3bef55e7ff0efffd5d971aa57
bonding: Check return of dev_set_promiscuity/allmulti

dev_set_promiscuity/allmulti might overflow.
Commit: "netdevice: Fix promiscuity and allmulti overflow" in net-next makes
dev_set_promiscuity/allmulti return error number if overflow happened.

In bond_alb and bond_main, we check all positive increment for promiscuity
and allmulti to get error return.
But there are still two problems left.
1. Some code path has no mechanism to signal errors upstream.
2. If there are multi slaves, it's hard to tell which slaves increment
   promisc/allmulti successfully and which failed.
So I left these problems to be FIXME.
Fortunately, the overflow is very rare case.

Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bonding/bond_alb.c
drivers/net/bonding/bond_main.c