]> git.karo-electronics.de Git - linux-beck.git/commit
sched/wait: Change wait_on_bit*() to take an unsigned long *, not a void *
authorPalmer Dabbelt <palmer@dabbelt.com>
Fri, 1 May 2015 04:19:56 +0000 (21:19 -0700)
committerIngo Molnar <mingo@kernel.org>
Fri, 8 May 2015 10:05:41 +0000 (12:05 +0200)
commit7e60598785f30cf3dc9e476cc0fc3feeb37a0c63
tree17a19e5a8fec950c2065e839073362cb19f89096
parentb76808e6808e34e7e78131d2b8cb0535622b8e9f
sched/wait: Change wait_on_bit*() to take an unsigned long *, not a void *

The implementations of wait_on_bit*() will only work with long-aligned
memory on systems that don't support misaligned loads and stores.

This patch changes the function prototypes to ensure that the compiler
will enforce alignment.

Running

  make defconfig
  make KFLAGS="-Werror"

seems to indicate that, as of c56fb6564dcd ("Fix a misaligned load
inside ptrace_attach()"), there are now no users of non-long-aligned
calls to wait_on_bit*().  I additionally tried a few "make randconfig"
attempts, none of which failed to compile for this reason.

Signed-off-by: Palmer Dabbelt <palmer@dabbelt.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Chris Metcalf <cmetcalf@ezchip.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: bobby.prani@gmail.com
Cc: oleg@redhat.com
Cc: paulmck@linux.vnet.ibm.com
Cc: richard@nod.at
Cc: vdavydov@parallels.com
Link: http://lkml.kernel.org/r/1430453997-32459-3-git-send-email-palmer@dabbelt.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
include/linux/wait.h