]> git.karo-electronics.de Git - karo-tx-linux.git/commit
drm/i915/huc: Avoid attempting to authenticate non-existent fw
authorMichał Winiarski <michal.winiarski@intel.com>
Fri, 20 Jan 2017 19:23:46 +0000 (20:23 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 20 Jan 2017 19:59:53 +0000 (19:59 +0000)
commit7e8d12bc733fc9deeb5d78140cda169030fa2ac5
treee4b5c7b41444ac77941f74ef55c2adf402ec76c5
parent7e79a6836cfd1bac20e2be3fafdc3caca27c9d69
drm/i915/huc: Avoid attempting to authenticate non-existent fw

HuC authentication is called even if HuC firmware is not present in the
system, leading to NULL ptr dereference on not allocated gem_object.
Let's avoid trying to authenticate HuC if its firmware is not loaded
successfully.

Fixes: dac84a388528 ("drm/i915/huc: Support HuC authentication")
v2: Check inside the auth function, split the assert (Michał)
v3: Oops, hit send before compiling, s/huc_fw/huc->fw

Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170120192348.2049-1-michal.winiarski@intel.com
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
drivers/gpu/drm/i915/intel_huc.c