]> git.karo-electronics.de Git - karo-tx-linux.git/commit
staging: iio: fix ad7606_spi regression
authorArnd Bergmann <arnd@arndb.de>
Mon, 30 May 2016 13:50:24 +0000 (15:50 +0200)
committerJonathan Cameron <jic23@kernel.org>
Sat, 11 Jun 2016 16:56:53 +0000 (17:56 +0100)
commit7e982555d89cc84b1fa23b5d54c7ffd9f7753908
tree90865ecb86cb66a0cc524deaa426aa63ca0a453b
parent6e85dbe4b461e59fa3cad6f6235cb47fa4c6a629
staging: iio: fix ad7606_spi regression

As pointed out by Geert Uytterhoeven, the patch was incorrect
and breaks the driver, which was fortunately pointed out by
this gcc warning:

drivers/staging/iio/adc/ad7606_spi.c: In function ‘ad7606_spi_read_block’:
drivers/staging/iio/adc/ad7606_spi.c:34: warning: ‘data’ is used uninitialized in this function

The effect of the patch is that the data is copied into
a random memory location (from the uninitialized pointer)
instead of being byteswapped in place.

This adds the initialization for the 'data' variable back
to restore the original behavior.

Cc: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Fixes: 87787e5ef727 ("Staging: iio: Fix sparse endian warning")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/staging/iio/adc/ad7606_spi.c