]> git.karo-electronics.de Git - karo-tx-linux.git/commit
sound: Prevent buffer overflow in OSS load_mixer_volumes
authorDan Rosenberg <drosenberg@vsecurity.com>
Sat, 25 Dec 2010 21:23:40 +0000 (16:23 -0500)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Sun, 17 Apr 2011 20:16:13 +0000 (16:16 -0400)
commit7eba652201dd791aa124afb1cabba6d4cc780072
tree01d837d04327053c47fa5cb648ee269dc5c606f8
parent19038636ecc62e79a089155d8576bcfce6dc0ab3
sound: Prevent buffer overflow in OSS load_mixer_volumes

commit d81a12bc29ae4038770e05dce4ab7f26fd5880fb upstream.

The load_mixer_volumes() function, which can be triggered by
unprivileged users via the SOUND_MIXER_SETLEVELS ioctl, is vulnerable to
a buffer overflow.  Because the provided "name" argument isn't
guaranteed to be NULL terminated at the expected 32 bytes, it's possible
to overflow past the end of the last element in the mixer_vols array.
Further exploitation can result in an arbitrary kernel write (via
subsequent calls to load_mixer_volumes()) leading to privilege
escalation, or arbitrary kernel reads via get_mixer_levels().  In
addition, the strcmp() may leak bytes beyond the mixer_vols array.

Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
sound/oss/soundcard.c