]> git.karo-electronics.de Git - karo-tx-linux.git/commit
srcu: Reduce probability of SRCU ->unlock_count[] counter overflow
authorPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Tue, 24 Jan 2017 16:51:34 +0000 (08:51 -0800)
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Wed, 25 Jan 2017 20:54:22 +0000 (12:54 -0800)
commit7f554a3d05bea9f6b7bf8e0b041d09447f82d74a
treed679d50032981ee84479dfaea34716ab1ac57d6d
parent418b2977b34378f67c46930c72a776f94e7bf903
srcu: Reduce probability of SRCU ->unlock_count[] counter overflow

Because there are no memory barriers between the srcu_flip() ->completed
increment and the summation of the read-side ->unlock_count[] counters,
both the compiler and the CPU can reorder the summation with the
->completed increment.  If the updater is preempted long enough during
this process, the read-side counters could overflow, resulting in a
too-short grace period.

This commit therefore adds a memory barrier just after the ->completed
increment, ensuring that if the summation misses an increment of
->unlock_count[] from __srcu_read_unlock(), the next __srcu_read_lock()
will see the new value of ->completed, thus bounding the number of
->unlock_count[] increments that can be missed to NR_CPUS.  The actual
overflow computation is more complex due to the possibility of nesting
of __srcu_read_lock().

Reported-by: Lance Roy <ldr709@gmail.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
kernel/rcu/srcu.c