]> git.karo-electronics.de Git - linux-beck.git/commit
media: solo6x10: fix lockup by avoiding delayed register write
authorAndrey Utkin <andrey.utkin@corp.bluecherry.net>
Sat, 22 Oct 2016 15:34:36 +0000 (13:34 -0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 9 Jan 2017 07:32:24 +0000 (08:32 +0100)
commit7f89c1373637395de72f53cb20a170fe24d1f371
tree62834952211f08f98ce14d6b0bff0f6939eb6d3f
parent3fbe140e9d360a31ec88ee1126df778b33dde9f2
media: solo6x10: fix lockup by avoiding delayed register write

commit 5fc4b067ec082c3127e0156f800769b7e0dce078 upstream.

This fixes a lockup at device probing which happens on some solo6010
hardware samples. This is a regression introduced by commit e1ceb25a1569
("[media] SOLO6x10: remove unneeded register locking and barriers")

The observed lockup happens in solo_set_motion_threshold() called from
solo_motion_config().

This extra "flushing" is not fundamentally needed for every write, but
apparently the code in driver assumes such behaviour at last in some
places.

Actual fix was proposed by Hans Verkuil.

Fixes: e1ceb25a1569 ("[media] SOLO6x10: remove unneeded register locking and barriers")
Signed-off-by: Andrey Utkin <andrey.utkin@corp.bluecherry.net>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/pci/solo6x10/solo6x10.h