]> git.karo-electronics.de Git - linux-beck.git/commit
cw1200: fix bogus maybe-uninitialized warning
authorArnd Bergmann <arnd@arndb.de>
Tue, 25 Oct 2016 20:21:04 +0000 (22:21 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 17 Nov 2016 06:47:58 +0000 (08:47 +0200)
commit7fc1503c906f0fac62d3506a6e993e49fb996248
tree918965779c54a0515082ed35a0642ec86509131c
parent10f3366b4d894ac6eb9f31931bd4c99895935f26
cw1200: fix bogus maybe-uninitialized warning

On x86, the cw1200 driver produces a rather silly warning about the
possible use of the 'ret' variable without an initialization
presumably after being confused by the architecture specific definition
of WARN_ON:

drivers/net/wireless/st/cw1200/wsm.c: In function ‘wsm_handle_rx’:
drivers/net/wireless/st/cw1200/wsm.c:1457:9: error: ‘ret’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

We have already checked that 'count' is larger than 0 here, so
we know that 'ret' is initialized. Changing the 'for' loop
into do/while also makes this clear to the compiler.

Suggested-by: David Laight <David.Laight@ACULAB.COM>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/st/cw1200/wsm.c