]> git.karo-electronics.de Git - karo-tx-linux.git/commit
iwlwifi: fix skb usage after free
authorStanislaw Gruszka <sgruszka@redhat.com>
Wed, 20 Apr 2011 13:57:14 +0000 (15:57 +0200)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Wed, 14 Mar 2012 14:57:53 +0000 (10:57 -0400)
commit8044fd5387ea8981bab15045a9001baad285da66
treea9c6f2fe6bed787b740fab9553f9e4c2bf76cf5b
parenta57cf6033eab330d6c8c966e105081c4b2c70050
iwlwifi: fix skb usage after free

commit b25026981aecde3685dd0e45ad980fff9f528daa upstream.

Since

commit a120e912eb51e347f36c71b60a1d13af74d30e83
Author: Stanislaw Gruszka <sgruszka@redhat.com>
Date:   Fri Feb 19 15:47:33 2010 -0800

    iwlwifi: sanity check before counting number of tfds can be free

we use skb->data after calling ieee80211_tx_status_irqsafe(), which
could free skb instantly.

On current kernels I do not observe practical problems related with
bug, but on 2.6.35.y it cause random system hangs when stressing
wireless link.

[PG: since 34, file renamed, + iwlagn_tx_status --> iwl_tx_status]

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Acked-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
drivers/net/wireless/iwlwifi/iwl-tx.c